Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Other] Deprecate --abort-on-first-error in favor of --no-recover as maintainence for the flag is not worth it #501

Open
1 task done
Luna-Klatzer opened this issue Aug 15, 2023 · 0 comments
Assignees
Labels
other Other development related change or issue
Milestone

Comments

@Luna-Klatzer
Copy link
Member

Luna-Klatzer commented Aug 15, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current State & Issue

Currently when wanting to run a compilation or execute a program without waiting for everything to be completed, the flag --abort-on-first-error or --no-recover can be specified. Both though have practically the same functionality and therefore don't change much for the user.

The current problem with --abort-on-first-error stems from the underlying compiler configuration CompileConfig.abortOnFirstError, which is directly bound to the flag of the CLI. This causes the compiler to throw an actual KipperError instance, which has to be accounted for in the CLI implementation.

As that introduces multiple edge cases it seems to make a lot more sense to entirely remove it in favor of --no-recover, as that also provides a clear distinction between recovering from errors and attempting to get all possible errors i.e. --recover and instantly aborting on the first error encountered i.e. --no-recover.

Note

With the next release 0.10.4 that fixes #491, --abort-on-first-error will be deprecated and marked for removal in 0.11.0.

@Luna-Klatzer Luna-Klatzer added the other Other development related change or issue label Aug 15, 2023
@Luna-Klatzer Luna-Klatzer added this to the v0.11.0 milestone Aug 15, 2023
@Luna-Klatzer Luna-Klatzer self-assigned this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other Other development related change or issue
Projects
Development

No branches or pull requests

1 participant