Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix bug in playground editor overflowing with size-modifying scrollbar #498

Open
1 of 3 tasks
Luna-Klatzer opened this issue Aug 7, 2023 · 0 comments
Open
1 of 3 tasks
Assignees
Labels
docs Related to the project docs and info on the repo or website high priority High priority issue, discussion or pull request
Milestone

Comments

@Luna-Klatzer
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current State & Issue

With the recent cleanups of the playground a bug was discovered, which causes the playground to incorrectly resize with size-modifying scrollbars.

This is due to the issue that browsers handle the width of a scrollbar usually different from one another and that sometimes it is included in the offsetHeight/offsetWidth properties of an element making it wider/taller than expected, but sometimes they may be just overlay elements with no width i.e. no influence on the element dimensions, like for example on most phone browsers (like with Firefox).

For example on Firefox 116.0 with size-modifying scrollbars this is the result:

grafik
Slightly overflowing code editor on the bottom edge

Reference function handling this:

Expected Changes & Improvements

  • The existing function setEditorAndConsoleSizes() should be cleaned up, so that the behaviour is more clear and that the code is also more maintainable.
  • The overflow bug should be fixed and tested across all major browsers/platforms, i.e. Firefox, Chrome, Edge, Firefox Mobile and Chrome Mobile.

Referenced sites

@Luna-Klatzer Luna-Klatzer added the docs Related to the project docs and info on the repo or website label Aug 7, 2023
@Luna-Klatzer Luna-Klatzer added this to the Improved Docs milestone Aug 7, 2023
@Luna-Klatzer Luna-Klatzer self-assigned this Aug 7, 2023
@Luna-Klatzer Luna-Klatzer changed the title [Docs] Fix bug in playground editor overflowing with scrollbar-browsers [Docs] Fix bug in playground editor overflowing with size-modifying scrollbar Aug 7, 2023
@Luna-Klatzer Luna-Klatzer added the high priority High priority issue, discussion or pull request label Aug 7, 2023
@Luna-Klatzer Luna-Klatzer pinned this issue Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to the project docs and info on the repo or website high priority High priority issue, discussion or pull request
Projects
Status: No status
Development

No branches or pull requests

1 participant